Added GM:OnDuplicated(ent, entDupeTable), GMod PR#528
Open
Grocel wants to merge 1 commit into
Open
Conversation
In adjacent to: Facepunch/garrysmod#2408 Works like `ENTITY:OnDuplicated(ent, entDupeTable)` but doesn't require adding/detouring `ent.OnDuplicated` on `OnEntityCreated` calls for addon-foreign entities.
Contributor
Author
|
The linter results are not relevant to my changes, so I can't fix them. |
Grocel
added a commit
to Grocel/sligwolf_addon_base
that referenced
this pull request
Dec 14, 2025
Removes the need for the "OnEntityCreated" hack. Requires these pull request to be merged: - Facepunch/garrysmod#2408 - wiremod/advdupe2#528
Contributor
|
I don't see any point in merging this until it's merged into GMOD. Because very few addons rely on the AdvDupe2 duplicator specifically |
Contributor
Author
Yeah, that's alright. It might change depending on how Rubat wants to have it done for GMod anyways. Rubat actually responded to the PR for GMod and asked for additional feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In adjacent to: Facepunch/garrysmod#2408
Works like
ENTITY:OnDuplicated(ent, entDupeTable)but doesn't require adding/detouringent.OnDuplicatedonOnEntityCreatedcalls for addon-foreign entities.This adds a easy way to add generic logic early to the duplication life cycle. It is called a way before
duplicator.RegisterEntityModifier()added callers are being iterated. The new hook also reduces the risk of conflicts caused by detours of pre-existingent.OnDuplicatedcode.Test script: